Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevents ready_to_laser if cpu is high (longer waiting time) #1235

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Prevents ready_to_laser if cpu is high (longer waiting time) #1235

wants to merge 3 commits into from

Conversation

andywerner
Copy link

No description provided.

@andywerner andywerner marked this pull request as ready for review April 16, 2021 09:00
amrsoll
amrsoll suggested changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@amrsoll amrsoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what happened to psutils? It would have been easy to install it through the usb keys as well.

octoprint_mrbeam/iobeam/onebutton_handler.py
Comment on lines +430 to +433
"wait_for_cpu_below() cpu_load: %s, cpu_max: %s, cpu_load > cpu_max: %s",
cpu_load,
cpu_max,
cpu_load > cpu_max,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it a debug log and without the function name

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@andywerner
Copy link
Author

PSutil:
https://psutil.readthedocs.io/en/latest/
https://pypi.org/project/psutil/

And this:
https://stackoverflow.com/questions/48761714/how-to-get-the-particular-process-cpu-usage-from-task-manager-in-windows-using-p

@amrsoll
Copy link
Contributor

amrsoll commented Apr 16, 2021

But why not use psutil then?

@ahmed-mrbeam ahmed-mrbeam force-pushed the develop branch 2 times, most recently from 202baee to bcd6b27 Compare September 28, 2021 13:05
@ahmed-mrbeam ahmed-mrbeam force-pushed the develop branch 2 times, most recently from c49d8eb to 5d6659c Compare October 1, 2021 10:15
@ahmed-mrbeam ahmed-mrbeam force-pushed the develop branch 2 times, most recently from 1f28493 to 6c61b35 Compare December 8, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrsoll amrsoll amrsoll approved these changes

@hungerpirat hungerpirat Awaiting requested review from hungerpirat

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andywerner @amrsoll