Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch bug in FileContainer.concat: switch to pd.Index.equals() instead of is comparison for equal keys #145

Merged

Conversation

veni-vidi-vici-dormivi
Copy link
Collaborator

Closes #143

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 99.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
filefisher/_filefinder.py 100.00% <100.00%> (ø)

Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changelog entry but otherwise good to go

@veni-vidi-vici-dormivi veni-vidi-vici-dormivi merged commit 5e06c4b into mpytools:main Jan 14, 2025
7 checks passed
@veni-vidi-vici-dormivi veni-vidi-vici-dormivi deleted the concat_patch branch January 14, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: is comparison (almost) always False for pandas.Index
2 participants