Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osxbundle: avoid running codesign with deprecated --deep argument #13379

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

davidkna
Copy link
Contributor

--deep is deprecated as of macos 13.0.
It is also not supported by alternative codesign implementations like
sigtool.

Related: NixOS/nixpkgs#270691

Read this before you submit this pull request:
https://github.com/mpv-player/mpv/blob/master/DOCS/contribute.md

Reading this link and following the rules will get your pull request reviewed
and merged faster. Nobody wants lazy pull requests.

@Akemi
Copy link
Member

Akemi commented Feb 25, 2024

sry for the late reply, i wanted to get some vulkan/moltenvk bundling changes into mpv before this.

anyway with 6b5b4b7 we are now bundling vulkan loaders (driver + layers) with the App bundle. because of that we have another folder where dylibs reside Contents/Frameworks, which possibly also need signing. those dylibs are not directly linked to the mpv binary but loaded dynamically by the vulkan loader and that's the reason why i didn't put them in the lib folder next to the mpv binary.

a bit sad about the --deep parameter, but can't be helped. maybe the function could be made a bit more generic, eg a list of folders/files that need to be signed and are iterated over.

`--deep` is deprecated as of macos 13.0.
It is also not supported by alternative `codesign`
implementations like
[sigtool](https://github.com/thefloweringash/sigtool).

Related: NixOS/nixpkgs#270691
@davidkna
Copy link
Contributor Author

davidkna commented Mar 2, 2024

@Akemi Thanks, I've updated the function to contain a list of directories with binaries to sign. I've also verified that it still works with -s if the Frameworks directory does not exist.

Copy link

github-actions bot commented Mar 2, 2024

Download the artifacts for this pull request:

Windows
macOS

@Akemi
Copy link
Member

Akemi commented Mar 7, 2024

thanks for your fix and contribution.

@Akemi Akemi merged commit 68fbdc8 into mpv-player:master Mar 7, 2024
14 checks passed
@davidkna davidkna deleted the bundle-deep branch March 7, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants