Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add bq dataViewer to folder_additional_roles #242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

corbanCloud
Copy link

@corbanCloud corbanCloud commented Dec 19, 2024

Code in https://github.com/mozilla/terraform-modules/blob/main/google_permissions/other_roles.tf suggests this should be a role allowed to be added to folder_roles input

This roles absence from the locals defined here causes the error "You have specified an invalid folder role." to be raised when this option is attempted

Changelog entry

fix disallowed usage of defined additional folder role`roles/bigquery.dataViewer`  as an input for `var.folder_roles` 

Code in https://github.com/mozilla/terraform-modules/blob/main/google_permissions/other_roles.tf suggests this should be a role allowed to be added to `folder_roles` input

This roles absence from the locals defined here causes the error "You have specified an invalid folder role." to be raised when this option is attempted
@corbanCloud corbanCloud changed the title Add bq dataViewer to folder_additional_roles fix: add bq dataViewer to folder_additional_roles Dec 19, 2024
@corbanCloud corbanCloud added the patch This PR will increment a patch version label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch This PR will increment a patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant