Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Google GKE Add ability to enable gateway api #149

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

bkochendorfer
Copy link
Member

@bkochendorfer bkochendorfer commented Jan 16, 2024

Default to standard channel

@bkochendorfer
Copy link
Member Author

I'm not sure what is best here, to pass in an enabled = true instead and default to STANDARD channel or use this and have the ability to pass in different channels.

@jasonthomas
Copy link
Member

I'm not sure what is best here, to pass in an enabled = true instead and default to STANDARD channel

I don't think we'd use the EXPERIMENTAL channel unless it's for testing purposes, and not sure if it would be easy to switch between them on an existing cluster. Being opinionated and simplifying to default to STANDARD channel seems reasonable to me.

@bkochendorfer
Copy link
Member Author

Agreed, thanks for the feedback @jasonthomas

@bkochendorfer bkochendorfer changed the title feat(gke): Add ability to enable gateway api and pass through channel… feat(gke): Add ability to enable gateway api Jan 16, 2024
@bkochendorfer bkochendorfer changed the title feat(gke): Add ability to enable gateway api feat: Google GKE Add ability to enable gateway api Jan 16, 2024
@bkochendorfer bkochendorfer merged commit f90df1c into main Jan 16, 2024
5 checks passed
@bkochendorfer bkochendorfer deleted the gateway-config branch January 16, 2024 17:51
Copy link

🎉 This PR is included in version 1.44.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants