-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circleci OIDC #148
Circleci OIDC #148
Conversation
9d3e204
to
d37ea54
Compare
@@ -1,11 +1,17 @@ | |||
variable "account_id" { | |||
type = string | |||
description = "Name of the service account. Defaults to deploy-<env>" | |||
description = "Name of the service account. Defaults to deploy-ENV." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the formattinng here because <env>
appears to get dropped in markdown conversion.
@jbuck this is ready for review, and I've included some examples as well. I think the default here might be a little dangerous compared to what we have for GHA since environment isn't a concept for CircleCI. We could consider making the default only use the https://github.com/mozilla-it/dataservices-infra/pull/137 was planned from this branch at the time of this comment, hopefully demonstrating that this is backwards compatible with all the existing GHA use cases. https://github.com/mozilla-services/cloudops-infra/pull/5387 contains the real-world examples I'm hoping to use this with. |
🎉 This PR is included in version 1.47.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Companion to https://github.com/mozilla-it/global-platform-admin/pull/1021. The changes here are backwards compatible with the existing module (count=1 counts as an internal state change and is otherwise a no-op). The assertions for CircleCI are somewhat bespoke to our specific mapping (though generally follow CircleCI's recommendation where possible) so this isn't necessarily a generic module usable outside of Mozilla.
It's possible to create an entirely separate module instead of using the one for github actions.
https://github.com/mozilla-services/cloudops-infra/compare/DSRE-1261?expand=1 contains a draft of how this module might be used to convert some of our existing data workloads from using static credentials in CI to OIDC.