Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace is-terminal with standard library #2311

Merged

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Jan 7, 2025

std::io::IsTerminal can be used as it is stabilized at Rust 1.70.

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@Xuanwo Xuanwo merged commit 9ca8beb into mozilla:main Jan 7, 2025
59 checks passed
@tottoto tottoto deleted the replace-is-terminal-with-standard-library branch January 7, 2025 15:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (0cc0c62) to head (2a5a71c).
Report is 131 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2311       +/-   ##
==========================================
- Coverage   30.91%       0   -30.92%     
==========================================
  Files          53       0       -53     
  Lines       20112       0    -20112     
  Branches     9755       0     -9755     
==========================================
- Hits         6217       0     -6217     
+ Misses       7922       0     -7922     
+ Partials     5973       0     -5973     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants