module_id file is not optional for cudafe++

mozilla · Jan 29, 2025 · 7766656 · 7766656
1 parent a3e9faa
commit 7766656
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/compiler/cicc.rs b/src/compiler/cicc.rs
@@ -58,7 +58,7 @@ impl CCompilerImpl for Cicc {
         cwd: &Path,
         _env_vars: &[(OsString, OsString)],
     ) -> CompilerArguments<ParsedArguments> {
-        parse_arguments(arguments, cwd, Language::Ptx, &ARGS[..], 3)
+        parse_arguments(arguments, cwd, Language::Ptx, &ARGS[..], 3, true)
     }
     #[allow(clippy::too_many_arguments)]
     async fn preprocess<T>(
@@ -107,6 +107,7 @@ pub fn parse_arguments<S>(
     language: Language,
     arg_info: S,
     input_arg_offset_from_end: usize,
+    module_id_file_optional: bool,
 ) -> CompilerArguments<ParsedArguments>
 where
     S: SearchableArgInfo<ArgData>,
@@ -205,7 +206,7 @@ where
                 "--module_id_file_name",
                 ArtifactDescriptor {
                     path: module_id_path,
-                    optional: true,
+                    optional: module_id_file_optional,
                 },
             );
         } else {

diff --git a/src/compiler/cudafe.rs b/src/compiler/cudafe.rs
@@ -59,7 +59,7 @@ impl CCompilerImpl for CudaFE {
         cwd: &Path,
         _env_vars: &[(OsString, OsString)],
     ) -> CompilerArguments<ParsedArguments> {
-        cicc::parse_arguments(arguments, cwd, Language::CudaFE, &ARGS[..], 1)
+        cicc::parse_arguments(arguments, cwd, Language::CudaFE, &ARGS[..], 1, false)
     }
     #[allow(clippy::too_many_arguments)]
     async fn preprocess<T>(

diff --git a/src/compiler/ptxas.rs b/src/compiler/ptxas.rs
@@ -59,7 +59,7 @@ impl CCompilerImpl for Ptxas {
         cwd: &Path,
         _env_vars: &[(OsString, OsString)],
     ) -> CompilerArguments<ParsedArguments> {
-        cicc::parse_arguments(arguments, cwd, Language::Cubin, &ARGS[..], 3)
+        cicc::parse_arguments(arguments, cwd, Language::Cubin, &ARGS[..], 3, true)
     }
     #[allow(clippy::too_many_arguments)]
     async fn preprocess<T>(