Correctly render the glyph outline when it has a stroke pattern #19361
Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/22f8cf9261f75fa/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e7cf1e9632763a0/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/22f8cf9261f75fa/output.txt Total script time: 28.91 mins
Image differences available at: http://54.241.84.105:8877/22f8cf9261f75fa/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e7cf1e9632763a0/output.txt Total script time: 59.07 mins
Image differences available at: http://54.193.163.58:8877/e7cf1e9632763a0/reftest-analyzer.html#web=eq.log |
It fixes mozilla#19360. Each glyph in the test case has a fill and a stroke pattern, so the current transform used to scale the glyph outline must be the same. In setting the stroke color to green, I noticed that the last outline contains some non-closed subpaths, so when generating the glyph outline, every time we 'moveTo', we close the previous subpath.
calixteman
force-pushed
the
issue19360
branch
from
be5722f to
1ccf6ed
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d7c2f41788f71b1/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c14ed8980c12937/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/c14ed8980c12937/output.txt Total script time: 28.88 mins
Image differences available at: http://54.241.84.105:8877/c14ed8980c12937/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d7c2f41788f71b1/output.txt Total script time: 58.69 mins
Image differences available at: http://54.193.163.58:8877/d7c2f41788f71b1/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/12f3216e27fb0ca/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b1ff2ac8bc0b738/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/12f3216e27fb0ca/output.txt Total script time: 16.68 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/b1ff2ac8bc0b738/output.txt Total script time: 30.03 mins
|
It fixes #19360.
Each glyph in the test case has a fill and a stroke pattern, so the current transform used to scale the glyph outline must be the same.
In setting the stroke color to green, I noticed that the last outline contains some non-closed subpaths, so when generating the glyph outline, every time we 'moveTo', we close the previous subpath.