Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the "checks that the viewer re-exports the expected API functionality" unit-test in Node.js #19358

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

By also running gulp generic-legacy before the Node.js unit-tests, we can enable one more test-case in Node.js environments.

…onality" unit-test in Node.js

By also running `gulp generic-legacy` before the Node.js unit-tests, we can enable one more test-case in Node.js environments.
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/904b6bb0ff3b40c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f6314eb6aaea51f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/904b6bb0ff3b40c/output.txt

Total script time: 2.35 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/f6314eb6aaea51f/output.txt

Total script time: 7.34 mins

  • Unit Tests: Passed

@timvandermeij timvandermeij merged commit 09a0a0f into mozilla:master Jan 26, 2025
9 checks passed
@timvandermeij
Copy link
Contributor

Good idea!

@Snuffleupagus Snuffleupagus deleted the Node-enable-web_pdfjsLib branch January 26, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants