Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aws security doc #86

Merged
merged 11 commits into from
Feb 26, 2019
Merged

Add aws security doc #86

merged 11 commits into from
Feb 26, 2019

Conversation

gene1wood
Copy link
Contributor

No description provided.

@gene1wood gene1wood requested a review from gdestuynder January 14, 2019 22:42
gdestuynder
gdestuynder suggested changes Jan 22, 2019
View reviewed changes
andrewkrug
andrewkrug previously approved these changes Jan 23, 2019
View reviewed changes
@gene1wood
Copy link
Contributor Author

@gdestuynder Thanks for the review. I've merged your suggestions, added details about the root user and replied to the remaining comments.

Would you take a look over the pending conversations and either resolve them if they sound ok or reply in them?

@gene1wood
Copy link
Contributor Author

@gdestuynder Would you take a look over the pending conversations and either resolve them if they sound ok or reply in them?

gdestuynder
gdestuynder suggested changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@gdestuynder gdestuynder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it at request changes due to the few first comments

@gene1wood
Copy link
Contributor Author

@gdestuynder would you look over the last remaining item and add your thoughts or approve this PR?

@gdestuynder
Copy link
Contributor

I added a comment, didnt see the notification previously

@gene1wood
Copy link
Contributor Author

@gdestuynder I've opened an issue (#94) to work through the possible change of our approach to cross account access grants.

Given that all the issues on this PR appear to have been resolved, would you clear your review and we can merge?

@gene1wood gene1wood merged commit fda6bd5 into mozilla:master Feb 26, 2019
@gene1wood gene1wood deleted the add-aws-security-doc branch February 26, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdestuynder gdestuynder gdestuynder approved these changes

@andrewkrug andrewkrug andrewkrug left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gene1wood @gdestuynder @andrewkrug