Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

HPKP is downgraded, update scoring to report presence/absence/preload #421

Closed
wants to merge 1 commit into from

Conversation

floatingatoll
Copy link
Contributor

@floatingatoll floatingatoll commented May 5, 2020

This removes most HPKP scoring functionality. The HPKP preload checks are left in place for now, but all other checks are reduced to 'header is present' or 'header is absent', both scored 0 and the former with a clear deprecation warning. Closes #422, but should be released in coordination with mozilla/http-observatory-website#172 and mozilla/infosec.mozilla.org#107.

@floatingatoll floatingatoll requested a review from april May 5, 2020 18:53
@floatingatoll
Copy link
Contributor Author

Note that I don't have a working test setup here yet, but I updated the unit tests as well.

@april
Copy link
Contributor

april commented May 6, 2020

Looks like the tests are failing:

nosetests httpobs/tests -e insert_test_result -e scored_test -e select_test_results -e test_retrieve --with-coverage --cover-package=httpobs

Should let you run them okay. :)

@floatingatoll
Copy link
Contributor Author

floatingatoll commented Jul 16, 2020

Corrected a scoring name typo, removed now-unused FIFTEEN_DAYS constant, fixed line length.

Restructured HPKP deprecation/preload checks to run on both HTTP and HTTPS requests. While HPKP technically wasn't valid over HPKP, in practice if the header is present on either we need to warn the user, and if the site is preloaded it does no harm to highlight that for HTTP.

@LeoMcA
Copy link
Contributor

LeoMcA commented Jan 25, 2024

Enough time has passed that HPKP no longer appears in Chromium's preload list any more, and we mark it as "obsolete" on MDN, so I removed the test in its entirety in #521

@LeoMcA LeoMcA closed this Jan 25, 2024
@floatingatoll floatingatoll deleted the deprecate-hpkp branch January 25, 2024 12:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace HPKP scoring with deprecation warning if present
3 participants