Fix incorrectly applied "removed" status for pings #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This bug is very visible if you look at the pings page for Fenix: https://dictionary.telemetry.mozilla.org/apps/fenix?itemType=pings&page=1
|
Iinh
approved these changes
Sep 13, 2021
|
Yuck, this actually only half-fixes the problem since app_ids suffer from the same thing. I think the right solution here is to only consider an item removed if the in_source annotation is actually false. Not all items have the "in source" annotation. Will update PR. |
wlach
force-pushed
the
fix-removed-status-for-pings
branch
3 times, most recently
from
9185a12 to
9e26e55
Compare
We'll say that an item is only removed if it (1) has an "in_source" annotation and it is false. This annotation should always be present for metrics, but is not currently set for any other object.
wlach
force-pushed
the
fix-removed-status-for-pings
branch
from
9e26e55 to
c281700
Compare
wlach
commented
Sep 13, 2021
| return item.in_source === false; | ||
| }; | ||
|
|
||
| export const isExpired = (item) => { |
There was a problem hiding this comment.
It felt like it would be best if these two methods took the same argument.
Iinh
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, we'll just say that they're always in source until we can
determine otherwise (see mozilla/probe-scraper#341)