Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): set line-height to improve global body legibility #722

Merged
merged 1 commit into from
May 13, 2019

Conversation

karansapolia
Copy link
Contributor

@karansapolia karansapolia commented Apr 3, 2019

fixes #591

continuation of mozilla/fxa-content-server#7079

@karansapolia
Copy link
Contributor Author

@ryanfeeley review please

Copy link
Contributor

@shane-tomlinson shane-tomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @karansapolia and I'm sorry for the delay in reviewing.

Using the generic p selector will apply this everywhere and that will most definitely break the layout in a lot of places. @ryanfeeley's original bug specifies:

Would love to see this applied to our terms of service, and privacy policy (24px line height).

That bug shows the altered line height applied to the cookies_disabled page.

Ryan also suggests using a 24px line height on the terms of service and privacy policy.

One final place where it might make sense is the update firefox template.

Can you make the selectors specific for now, we can try to make things more general in the future, but that's not a task I think you should take on here because it's could be a doozy ensuring everything looks just as it should.

@karansapolia
Copy link
Contributor Author

One final place where it might make sense is the update firefox template.

Can you make the selectors specific for now, we can try to make things more general in the future, but that's not a task I think you should take on here because it's could be a doozy ensuring everything looks just as it should.

Done. @shane-tomlinson r+? Would also request you to rerun the tests.

Copy link
Contributor

@shane-tomlinson shane-tomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+, thanks @karansapolia!

@shane-tomlinson shane-tomlinson merged commit c079c08 into mozilla:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve legibility of body copy by increasing line height
2 participants