Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next): add support for payments-next.ftl #884

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

StaberindeZA
Copy link
Contributor

Because:

  • The Subscription Platform team is adding a new app service, payments-next, to replace the existing fxa-payments-server. In the short term both payments-next and fxa-payments-server need to be supported, each utilizing different ftl strings.

This commit:

  • Adds support for new app payments-next utilizing payments-next.ftl

Closes #FXA-7482

@StaberindeZA StaberindeZA requested a review from a team as a code owner January 7, 2025 17:16
@StaberindeZA
Copy link
Contributor Author

@bcolsson as discussed last year, this PR will add support for the new Subscription Platform app service Payments Next, as part of the Subscription Platform 3.0 project.

Along with this change, there is also a script that has been created that ports over existing translations from locale/**/payments.ftl to locale/**/payments-next.ftl where an existing translation is available.

I'll reach out to you directly to discuss further.

.github/workflows/l10n_extract.yaml Outdated Show resolved Hide resolved
Because:

- The Subscription Platform team is adding a new app service,
  payments-next, to replace the existing fxa-payments-server. In the
  short term both payments-next and fxa-payments-server need to be
  supported, each utilizing different ftl strings.

This commit:

- Adds support for new app payments-next utilizing payments-next.ftl

Closes #FXA-7482
@StaberindeZA StaberindeZA force-pushed the fxa-7842-support-payments-next branch from 0ba22ef to d0ecbaf Compare January 8, 2025 17:36
@bcolsson bcolsson merged commit 352bdd4 into main Jan 8, 2025
@bcolsson bcolsson deleted the fxa-7842-support-payments-next branch January 8, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants