-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build.rs config to use rust backends. #91
Add build.rs config to use rust backends. #91
Conversation
Do you mind fixing the |
Sorry about the noise on this; I accidentally pushed what I intended for #93 to this branch. |
This one is also still a bit of a WIP; for example, it perhaps should pin to a specific commit hash of the backends? I also need to figure out how to conditionally link against the debug builds or the release builds depending on the release mode. |
8b33bc9
to
435c369
Compare
Perhaps we can make cubeb have cubeb-coreaudio-rs and cubeb-pulse-rs as submodules so that we can pin them to a specific version? |
435c369
to
74ac932
Compare
Note that this is blocked on mozilla/cubeb-pulse-rs#94 and mozilla/cubeb-coreaudio-rs#236 being merged, cubeb's submodules for them updating accordingly, AND this PR updating the submodule of cubeb in cubeb-rs. |
The first few steps are done -- cubeb-pulse-rs and cubeb-coreaudio-rs have the necessary updates. Next up is mozilla/cubeb#801, then an update to this PR to bump cubeb's pinned commit. |
74ac932
to
ea6cc5f
Compare
Update libcubeb to ffd5184, which grabs the rust backends for pulse and audiounit.
Once rust-lang/cargo#6745 is fixed, this `exclude` section will work and do what we need, but for now it is a no-op.
db04258
to
4824a65
Compare
hmm, this is silently failing to build on linux when pulse is available... working on that now. |
Should be good now. There's a slight gap in CI -- I don't believe libpulse-dev is installed for the CI environment, so any problems that occur when libpulse is present on linux will be missed by CI -- but it does now build and pass tests with pulse |
I opened a PR to fix the CI, but this looks good, thanks for the patch and mentioning the issue. |
No description provided.