Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build.rs config to use rust backends. #91

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

mutexlox-signal
Copy link
Contributor

No description provided.

@padenot
Copy link
Collaborator

padenot commented Sep 11, 2024

Do you mind fixing the if ... statements? that looks like debug code you forgot to remove. Thanks for the patch in any case, looks good for merging except this issue.

@mutexlox-signal
Copy link
Contributor Author

Sorry about the noise on this; I accidentally pushed what I intended for #93 to this branch.

@mutexlox-signal
Copy link
Contributor Author

This one is also still a bit of a WIP; for example, it perhaps should pin to a specific commit hash of the backends? I also need to figure out how to conditionally link against the debug builds or the release builds depending on the release mode.

@mutexlox-signal mutexlox-signal force-pushed the mutexlox/build-rust-backends branch from 8b33bc9 to 435c369 Compare September 11, 2024 14:53
@mutexlox-signal
Copy link
Contributor Author

Perhaps we can make cubeb have cubeb-coreaudio-rs and cubeb-pulse-rs as submodules so that we can pin them to a specific version?

@mutexlox-signal mutexlox-signal force-pushed the mutexlox/build-rust-backends branch from 435c369 to 74ac932 Compare September 26, 2024 15:41
@mutexlox-signal
Copy link
Contributor Author

Note that this is blocked on mozilla/cubeb-pulse-rs#94 and mozilla/cubeb-coreaudio-rs#236 being merged, cubeb's submodules for them updating accordingly, AND this PR updating the submodule of cubeb in cubeb-rs.

@mutexlox-signal
Copy link
Contributor Author

The first few steps are done -- cubeb-pulse-rs and cubeb-coreaudio-rs have the necessary updates. Next up is mozilla/cubeb#801, then an update to this PR to bump cubeb's pinned commit.

@mutexlox-signal mutexlox-signal force-pushed the mutexlox/build-rust-backends branch from 74ac932 to ea6cc5f Compare October 16, 2024 13:59
Update libcubeb to ffd5184, which grabs the rust backends for pulse and
audiounit.
Once rust-lang/cargo#6745 is fixed, this
`exclude` section will work and do what we need, but for now it is a
no-op.
@mutexlox-signal mutexlox-signal force-pushed the mutexlox/build-rust-backends branch from db04258 to 4824a65 Compare October 16, 2024 18:18
@mutexlox-signal
Copy link
Contributor Author

hmm, this is silently failing to build on linux when pulse is available... working on that now.

@mutexlox-signal mutexlox-signal marked this pull request as ready for review October 16, 2024 19:08
@mutexlox-signal
Copy link
Contributor Author

Should be good now. There's a slight gap in CI -- I don't believe libpulse-dev is installed for the CI environment, so any problems that occur when libpulse is present on linux will be missed by CI -- but it does now build and pass tests with pulse

@padenot
Copy link
Collaborator

padenot commented Oct 17, 2024

I opened a PR to fix the CI, but this looks good, thanks for the patch and mentioning the issue.

@padenot padenot merged commit e6e74b6 into mozilla:master Oct 17, 2024
7 checks passed
@mutexlox-signal mutexlox-signal deleted the mutexlox/build-rust-backends branch October 17, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants