Correctly choose profile to use. #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If, e.g., a user sets `CARGO_PROFILE_RELEASE_DEBUG=1`, the `DEBUG` environment variable will be set accordingly, and so the debug build will be used. Instead, we should use the PROFILE env variable (see https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-build-scripts) to determine which profile to use. This isn't 100% correct, because it won't pass through any other flags (in this case, we won't have debug information for the cubeb backend), but it is more correct to ensure the matching profile.
|
cc @kinetiknz for review |
|
Not entirely sure what the build failures here are but they do look similar to https://github.com/mozilla/cubeb-rs/actions/runs/12285548106/job/34283783653#step:6:159. I don't think it's reproducing for me locally, though, and the error we do see in github isn't helpful... |
|
Thanks! The build failures appear to be caused by clippy warnings on the cubeb crates inside the vendored libcubeb. I'll look at changing libcubeb's CMakeLists.txt to report these errors to the console so we get legible errors in CI. |
mozilla/cubeb@842a3c7 solves this particular issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If, e.g., a user sets
CARGO_PROFILE_RELEASE_DEBUG=1, theDEBUGenvironment variable will be set accordingly, and so the debug build will be used.Instead, we should use the PROFILE env variable (see https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-build-scripts) to determine which profile to use.
This isn't 100% correct, because it won't pass through any other flags (in this case, we won't have debug information for the cubeb backend), but it is more correct to ensure the matching profile.