feat(dryrun): Pass all query parameters when dry-running queries #6835
+42
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWu
reviewed
Jan 17, 2025
| query_parameters = [] | ||
| scheduling_metadata = self.metadata.scheduling if self.metadata else {} | ||
| if date_partition_parameter := scheduling_metadata.get( | ||
| "date_partition_parameter", "submission_date" |
There was a problem hiding this comment.
Does submission_date need to be set if if there's no date_partition_parameter?
There was a problem hiding this comment.
If date_partition_parameter isn't specified at all in the scheduling metadata then it does default to passing a @submission_date parameter, so dryrun should too. However, if date_partition_parameter is set to null in the scheduling metadata then no @submission_date parameter is passed by default, so this does the same in that case (the "date_partition_parameter" key will exist in the scheduling dictionary, so the get() will return the null value as None which won't pass the if check).
There was a problem hiding this comment.
Oh I see. I didn't know it did that
Co-authored-by: Ben Wu <[email protected]>
BenWu
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
bqetl dryruncommand doesn't currently support queries which use any non-date query parameters. This PR adds support for such queries by passing all expected query parameters when dry-running queries.This depends on mozilla-services/cloudops-infra#6189 to update the
bigquery_etl_dryrunGoogle Cloud function to accept query parameters as an argument.Related Tickets & Documents
Reviewer, please follow this checklist
┆Issue is synchronized with this Jira Task