Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT merge] - Set retention on client_level tables for glean_usage tables #6815

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[DO NOT merge] - Set retention on client_level tables for glean_usage tables #6815

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
05d9dc6
Set retention on client_level tables for glean_usage tables
alekhyamoz Jan 15, 2025
7c30878
Add table_type label for event_stream table
alekhyamoz Jan 15, 2025
051ee24
change 780 to 775
alekhyamoz Jan 15, 2025
628dfda
Add some more client level glean usage tables
alekhyamoz Jan 16, 2025
ecd153f
Add some more client level glean usage tables
alekhyamoz Jan 16, 2025
1cbaefa
Fix based on reviews
alekhyamoz Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sql/moz-fx-data-shared-prod/firefox_desktop_derived/pageload_1pct_v1/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ owners:
- [email protected]
labels:
incremental: true
table_type: client_level
scheduling:
dag_name: bqetl_pageload_v1
task_name: firefox_desktop_pageload_1pct__v1
Expand All @@ -16,7 +17,7 @@ bigquery:
type: day
field: submission_timestamp
require_partition_filter: true
expiration_days: 780
expiration_days: 775
range_partitioning: null
clustering:
fields:
Expand Down
3 changes: 2 additions & 1 deletion sql/moz-fx-data-shared-prod/firefox_desktop_derived/pageload_nightly_v1/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ owners:
- [email protected]
labels:
incremental: true
table_type: client_level
scheduling:
dag_name: bqetl_pageload_v1
task_name: firefox_desktop_pageload_nightly__v1
Expand All @@ -16,6 +17,6 @@ bigquery:
type: day
field: submission_timestamp
require_partition_filter: true
expiration_days: 780
expiration_days: 775
range_partitioning: null
references: {}
1 change: 1 addition & 0 deletions sql_generators/glean_usage/templates/baseline_clients_daily_v1.metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ bigquery:
type: day
field: submission_date
require_partition_filter: true
expiration_days: 775
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, what number should be used for expiration days? I have seen 780 as well:

bigquery-etl/sql/moz-fx-data-shared-prod/firefox_ios_derived/active_users_aggregates_v1/metadata.yaml

Line 23 in b81a7a0

expiration_days: 780

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the recent data retention sync meeting, we discussed and decided to use 775. The above PR was before a number was finalized. Open to suggestions or discussions if needed.

Copy link
Collaborator

@scholtzan scholtzan Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the 780 to 775 in a separate PR? To make it consistent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed 780 to 775 for a couple of tables. This file is deprecated and I will add it to my to-be-deleted list
ql/moz-fx-data-shared-prod/firefox_ios_derived/active_users_aggregates_v1/metadata.yaml#L23

clustering:
fields:
- normalized_channel
Expand Down
2 changes: 2 additions & 0 deletions sql_generators/glean_usage/templates/baseline_clients_last_seen_v1.metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ owners:
labels:
incremental: true
schedule: daily
table_type: client_level
scheduling:
dag_name: bqetl_glean_usage
task_group: {{ app_name }}
Expand All @@ -21,6 +22,7 @@ bigquery:
type: day
field: submission_date
require_partition_filter: true
expiration_days: 775
clustering:
fields:
- normalized_channel
Expand Down
2 changes: 2 additions & 0 deletions sql_generators/glean_usage/templates/events_stream_v1.metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ owners:
labels:
incremental: true
schedule: daily
table_type: client_level
scheduling:
dag_name: bqetl_glean_usage
task_group: {{ app_name }}
Expand All @@ -26,6 +27,7 @@ bigquery:
type: day
field: submission_timestamp
require_partition_filter: true
expiration_days: 775
clustering:
fields:
- sample_id
Expand Down
2 changes: 2 additions & 0 deletions sql_generators/glean_usage/templates/metrics_clients_daily.metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ owners:
labels:
incremental: true
schedule: daily
table_type: client_level
scheduling:
dag_name: bqetl_glean_usage
task_group: {{ app_name }}
Expand All @@ -15,6 +16,7 @@ bigquery:
type: day
field: submission_date
require_partition_filter: true
expiration_days: 775
clustering:
fields:
- normalized_channel
Expand Down