-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add partnership field to the active_users_aggregates view template #6706
feat: add partnership field to the active_users_aggregates view template #6706
Conversation
This comment has been minimized.
This comment has been minimized.
eacdacc
to
4690342
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to add partnership to telemetry.active_users_aggregates
to reflect in Looker?
9c8ebc4
to
0cddd56
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @bochocki are you happy to merge this before the code freeze?
@kik-kik This change may result in a slower respond due to the additional transformations. Since the KPI dashboards query |
We chatted with @bochocki about this and he mentioned that after December 15th was fine to make these changes. Also, this transformation would only apply when used and even then I don't think this would cause any performance issues. |
…ate to support KPI filtering for partnership specific data
…ad of the template
0cddd56
to
c090d24
Compare
Integration report for "feat: add partnership to telemetry.active_users_aggregates view instead of the template"
|
feat: add partnership field to the active_users_aggregates view template
Description
This change ads an additional field to the active_users_aggregates view which maps the distribution_id to a device partner to enable filtering of the KPI dashboards for this specific user segment.
This is an alternative to turning the active_users_aggregates in lookml to support this filtering. For more info on this approach see: mozilla/looker-spoke-default#984