Skip to content

Commit

Permalink
Prevent JS errors on IE8 (#15871)
Browse files Browse the repository at this point in the history
* Prevent loading GA on IE8 and below (Issue #15867)

* Prevent loading newsletter JS on old IE (Issue #15867)
  • Loading branch information
alexgibson authored Jan 16, 2025
1 parent 2dfdef4 commit 95a5abb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion bedrock/base/templates/base-protocol.html
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@

{% block js_pretrack %}{# include JavaScript that must be run pre GA tracking here #}{% endblock %}
{% block google_analytics %}
{% include 'includes/google-analytics.html' %}
<!--[if IE 9]><!-->
{% include 'includes/google-analytics.html' %}
<!--<![endif]-->
{% endblock %}
</head>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ <h2 class="moz24-footer-heading-social">{{ ftl('footer-refresh-follow-firefox')

{% block footer_js %}
{% if show_newsletter %}
{{ js_bundle('newsletter') }}
<!--[if !IE]><!-->
{{ js_bundle('newsletter') }}
<!--<![endif]-->
{% endif %}
{% endblock %}

0 comments on commit 95a5abb

Please sign in to comment.