Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version print #38

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Version print #38

wants to merge 3 commits into from

Conversation

sagudev
Copy link
Contributor

@sagudev sagudev commented Jun 18, 2021

This PR fixes two typos, adds version example which is also run in CI.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea for the global version() to serve as an example? or is it meant to be used in the CI? If the latter, we could just print the result of JS_GetImplementationVersion() directly.

@sagudev
Copy link
Contributor Author

sagudev commented Jun 19, 2021

It is to serve as mini example for impl native functions, because I only find them in cookbook, which is maybe too big. Running it in CI is just because someone mention that it would be good to test examples running. Should we run more examples?

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, anyone else want to take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants