-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBS-384: upgrade ESLint to v8 #6893
Conversation
@toufali Can you adjust the commit messages to match our conventions?: https://socorro.readthedocs.io/en/latest/dev.html#git-conventions In this case, the issues are obs issues, so it should be something like this:
and:
|
webapp/package.json
Outdated
"graceful-fs": "4.2.4", | ||
"prettier": "2.1.2", | ||
"prettier": "^3.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why define a minimum rather than pinning to a specific version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willkg when it's not a critical dependency I often use a minimum in case of minor patches. But I'm happy to pin it if you prefer!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We update this stuff rarely, so I'm wondering whether it's better to pin it and then re-enable dependabot to update things. That way it doesn't change without us approving it.
So in this case, I think we should pin it to specific versions rather than specify a minimum.
Sorry @willkg – I assumed since they get squashed anyway that it didn't really matter, but I see now that the commits are linked to the jira ticket which helps with reviews. I will fix these and try to remember for next time! |
e6602aa
to
1d33b74
Compare
@toufali : We landed the PR that removes legacy ES from Socorro. Can you rebase this against main tip? Then I can review it. |
14b8d57
to
d555f1e
Compare
@willkg – rebase done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The only change I'd like to make is for us to pin the dependencies in package.json
to specific versions. Let's make that change and then we can land this.
In order to support more modern ECMAScript required for the front-end refactor, we need to upgrade ESLint, which currently blocks merging of the new FE code.
Unfortunately, ESLint 9 dropped support for Node < v18.18 – we’re currently on Node v14. ESLint 8 still supports Node v14.
For additional context, see ticket: https://mozilla-hub.atlassian.net/browse/OBS-478