bug-1945553: Fix json encoding error with empty aggregations object #6882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@relud : I filed a bug for this issue, bug-1945553. Can you update your PR/ticket title before merging and attach the PR to the bug when you get a chance? |
relud
changed the title
relud
force-pushed
the
relud-fix-json-agg-type
branch
from
c9507b2 to
edd3b50
Compare
relud
force-pushed
the
relud-fix-json-agg-type
branch
from
edd3b50 to
11279bf
Compare
willkg
approved these changes
Feb 4, 2025
Comment on lines
430
to
432
| aggregations = getattr(results, "aggregations", {}) | ||
| if aggregations: | ||
| if isinstance(aggregations, AggResponse): | ||
| aggregations = self.format_aggregations(aggregations) |
There was a problem hiding this comment.
With ES 8, the results value either:
- does not have an
aggregationsattribute at all in which case theaggregationsvariable points to a{}value - does have an
aggregationsattribute which points to aAggResponseobject in which case, that gets run throughformat_aggregations()which returns a dict
That seems good to me.
aggregations points to a value with two very different types. We're not doing type checking, so it's just mildly not great. If we were to switch to type checking, then this would be more obviously not great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for es8+ search results may contain an AggResponse object under the
aggregationskey, instead a missing attribute like in es1.4, so here we convert that empty object to a dict