Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBS-427: Support verify_certs with self-issued certs for elastic cloud #6874

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

relud
Copy link
Member

@relud relud commented Jan 23, 2025

This only impacts https urls, which right now we only use for elastic cloud.

In stage we are currently depending on verify_certs=False to connect to elastic cloud, and this will allow us to instead use a certs.pem provided by elastic cloud to verify their https certs.

@relud relud requested a review from a team as a code owner January 23, 2025 22:32
@relud relud force-pushed the relud-obs-427-trust-ec-ca branch from b116840 to 3de05b8 Compare January 23, 2025 22:51
@relud relud force-pushed the relud-obs-427-trust-ec-ca branch from 3de05b8 to ecfbbb0 Compare January 23, 2025 23:04
Copy link
Contributor

@smarnach smarnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes are looking good – it's basically just a new configuration setting that's passed through several layers of indirection.

I wonder whether there's a reasonable way to enable SSL in the local stack for testing purposes, and whether that's a useful thing to do.

@relud
Copy link
Member Author

relud commented Jan 24, 2025

I wonder whether there's a reasonable way to enable SSL in the local stack for testing purposes, and whether that's a useful thing to do.

i could do it, but i'm inclined to think it's not that helpful.

@relud relud added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit aa5b567 Jan 24, 2025
1 check passed
@relud relud deleted the relud-obs-427-trust-ec-ca branch January 24, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants