Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1860947 - Add ReleaseData and string buffer AddRef and Release methods to the irrelevant signature list #6622

Merged
merged 1 commit into from
May 23, 2024

Conversation

amccreight
Copy link
Contributor

nsStringBuffer:: is still on the prefix list, but I don't actually see any instances of it besides AddRef and Release, so I'll leave it alone.

@amccreight amccreight requested a review from a team as a code owner May 22, 2024 14:04
@smarnach
Copy link
Contributor

Thanks for the pull request! Here are some signature changes caused by this PR. Do they look like what you'd expect?

Crash id: 210f59f6-ed83-4f4d-a244-f53d90240521
Original: mozilla::StringBuffer::Release
New:      nsTSubstring<T>::Finalize | nsTSubstring<T>::~nsTSubstring | mozilla::MemoryMapping::~MemoryMapping
Same?:    False

Crash id: 530d1ddf-2bb4-4385-9ed6-5eee10240522
Original: mozilla::StringBuffer::Release
New:      nsTSubstring<T>::Finalize | mozilla::dom::LSInitializationInfo::~LSInitializationInfo
Same?:    False

Crash id: d9531bea-662b-4a16-9af8-cc4770240518
Original: mozilla::StringBuffer::Release
New:      nsTSubstring<T>::~nsTSubstring | mozilla::DefaultDelete<T>::operator()
Same?:    False

Crash id: 6cfabd88-cd21-4617-9e50-69cc50240517
Original: mozilla::StringBuffer::AddRef
New:      mozilla::dom::DOMString::RelinquishBufferOwnership
Same?:    False

Crash id: b3adf56d-20da-4da7-bccb-0024a0240516
Original: shutdownhang | nsStringBuffer::Release | ReleaseData | nsTSubstring<T>::~nsTSubstring | mozilla::DefaultDelete<T>::operator()
New:      shutdownhang | nsTSubstring<T>::~nsTSubstring | mozilla::DefaultDelete<T>::operator()
Same?:    False

Crash id: f9180e76-ab40-4829-97b8-56ff20240516
Original: nsStringBuffer::Release | ReleaseData | nsTSubstring<T>::Finalize | mozilla::dom::StringBlobImpl::~StringBlobImpl
New:      nsTSubstring<T>::Finalize | mozilla::dom::StringBlobImpl::~StringBlobImpl
Same?:    False

Crash id: 64286038-e57b-4d54-97c7-3a7870240516
Original: nsStringBuffer::AddRef | nsTSubstring<T>::Assign | mozilla::dom::BlobSet::AppendUTF8String
New:      nsTSubstring<T>::Assign | mozilla::dom::BlobSet::AppendUTF8String
Same?:    False

I also noticed that there are crash reports with nsStringBuffer:: in the signature that are neither nsStringBuffer::AddRef nor nsStringBuffer::Release, e.g.

The signatures of these reports will be left unchange by this PR.

If this is what you expect, the PR looks good to me.

@amccreight
Copy link
Contributor Author

Yes, that all looks fine to me. Thanks.

The other string buffer methods seem to be very rare so I think that's okay.

…thods to the irrelevant signature list

nsStringBuffer:: is still on the prefix list, but I don't actually see any instances of it besides AddRef and Release, so I'll leave it alone.
@smarnach smarnach merged commit fa97274 into mozilla-services:main May 23, 2024
2 checks passed
@amccreight amccreight deleted the patch-2 branch June 26, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants