Chore/update 202403 #665
Merged
Chore/update 202403 #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
requested changes
Apr 2, 2024
| @@ -44,17 +44,17 @@ tokio.workspace = true | |||
| url.workspace = true | |||
| uuid.workspace = true | |||
|
|
|||
| a2 = { version = "0.8", git = "https://github.com/mozilla-services/a2", branch = "master" } | |||
| a2 = { version = "0.8" } | |||
There was a problem hiding this comment.
I guess we finally got all our stuff merged in to a release
| @@ -119,7 +119,7 @@ impl RouterError { | |||
| match self { | |||
| RouterError::Adm(e) => e.status(), | |||
| RouterError::Apns(e) => e.status(), | |||
| RouterError::Fcm(e) => e.status(), | |||
| RouterError::Fcm(e) => StatusCode::from_u16(e.status().as_u16()).unwrap_or_default(), | |||
There was a problem hiding this comment.
That's annoying, hopefully this will go away at some point (until it maybe happens again) actix/actix-web#3208 (comment)
There was a problem hiding this comment.
Yeah, to be honest, though, this is just the latest when it comes to this sort of refactoring. base64 was the last one to do something like this. I expect some other key library to be the next.
And then I get to deal with protobuf3 fun.
Right, so, Apparently you do need "PayloadLike" as a type declaration in order for `payload.to_json_string()` to work. You could also call `PayloadLike` directly if you wanted. We'll use the implicit function.
pjenvey
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: the bump for actix and reqwest appears to have caused a bit of divergence around
StatusCode. I'm not super happy with the fix, but it works, and we shouldn't get any odd status codes that don't work between versions.