Refactor Issue-4034 Update secrets name

[isabelrios]

Please see issue #4034
The secrets with the new. name have been already created in Bitrise with the value they have, that has not changed, only the name.

[isabelrios]

I would need your help... @adudenamedruby @jhugman @razvanlitianu, do you know if we need these?

NIMBUS_APP_NAME
NIMBUS_APP_CHANNEL
NIMBUS_STAGING_SERVER

in here (and lines below)

focus-ios/bitrise.yml

Line 274 in 2a6719c

/usr/libexec/PlistBuddy -c "Add :NimbusStagingServerURL string ${NIMBUS_STAGING_SERVER_URL}" focus-ios/Blockzilla/Info.plist

We don't have those in Firefox-iOS, so wondering if we should create those when we move focus or it is fine to remove them... Thanks!

[razvanlitianu]

hey @isabelrios it might be the case Nimbus configuration changed for Firefox and it was not updated for Focus. It seems for Firefox we use NimbusAppSettings and in Focus we use NimbusServerSettings.

[isabelrios]

NimbusAppSettings

Thanks for your reply @razvanlitianu ... I don't see that secret created for firefox though... I was referring to these ones:

NIMBUS_APP_NAME
NIMBUS_APP_CHANNEL
NIMBUS_STAGING_SERVER

The only one I see in firefox related to nimbus is NIMBUS_URL so I'm wondering if we need the rest... we can keep it, just to understand why we have those 3 more

[adudenamedruby]

I don't know anything about Focus and how we've implemented Nimbus there, so I don't have a proper answer.

But... I mean.... we can remove them and see if things break? lol Or just keep them and not worry about it for now.

[isabelrios]

I don't know anything about Focus and how we've implemented Nimbus there, so I don't have a proper answer.

But... I mean.... we can remove them and see if things break? lol Or just keep them and not worry about it for now.

Sure, let's keep them for now, I was trying not to move unused things to simplify and do a bit of clean up :)