Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-11168 [Content Sharing Opt] Telemetry to track start up time for deeplinks (backport #24422) #24483

Open
wants to merge 1 commit into
base: release/v135
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 31, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

Added Telemetry to track start up time when opening a deep link. Refactor ShareTelemetry to include method for measuring startup time. Adjusted ShareActivityTelemetryItemProviderTests with refactored ShareTelemetry.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

This is an automatic backport of pull request #24422 done by [Mergify](https://mergify.com).

…e for deeplinks (#24422)

* Add telemetry for deeplink, refactor ShareTelemetry to include deep links recording and GleanWrapper dependency

* Added correct startup open url time record

* Added test for Share Telemetry

* Remove unused code and added data review link

* Update record startup time telemetry name and code

* Correct typo

---------

Co-authored-by: Filippo <[email protected]>
(cherry picked from commit d17d22b)

# Conflicts:
#	firefox-ios/Client/Application/AppDelegate.swift
#	firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
Copy link
Contributor Author

mergify bot commented Jan 31, 2025

Cherry-pick of d17d22b has failed:

On branch mergify/bp/release/v135/pr-24422
Your branch is up to date with 'origin/release/v135'.

You are currently cherry-picking commit d17d22be9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   firefox-ios/Client.xcodeproj/project.pbxproj
	modified:   firefox-ios/Client/Application/SceneDelegate.swift
	modified:   firefox-ios/Client/Coordinators/Browser/BrowserCoordinator.swift
	modified:   firefox-ios/Client/Frontend/Browser/Event Queue/AppEvent.swift
	modified:   firefox-ios/Client/Frontend/Share/ShareTelemetry.swift
	modified:   firefox-ios/Client/Frontend/Share/ShareTelemetryActivityItemProvider.swift
	modified:   firefox-ios/Client/metrics.yaml
	modified:   firefox-ios/firefox-ios-tests/Tests/ClientTests/Mocks/MockBrowserViewController.swift
	deleted:    firefox-ios/firefox-ios-tests/Tests/ClientTests/Sharing/Mocks/MockShareTelemetry.swift
	modified:   firefox-ios/firefox-ios-tests/Tests/ClientTests/Sharing/ShareTelemetryActivityItemProviderTests.swift
	modified:   firefox-ios/firefox-ios-tests/Tests/ClientTests/Sharing/ShareTelemetryTests.swift

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   firefox-ios/Client/Application/AppDelegate.swift
	both modified:   firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested a review from a team as a code owner January 31, 2025 15:50
@mergify mergify bot added the conflicts label Jan 31, 2025
@mergify mergify bot requested review from MattLichtenstein and removed request for a team January 31, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant