Refactor FXIOS-11245 Replace ActionToast usage in RemoteTabsTableViewController with ButtonToast #24475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! The screenshots seems to be in the normal tabs tray, but the changes are in the remote tab tray 🤔 I think there's adjustements needed there |
|
This pull request has conflicts when rebasing. Could you fix it @bmihai23? 🙏 |
mattreaganmozilla
approved these changes
Feb 3, 2025
firefox-ios/Client/Frontend/Browser/Tabs/Views/RemoteTabsTableViewController.swift
Outdated
Show resolved
Hide resolved
firefox-ios/Client/Frontend/Browser/Tabs/Views/RemoteTabsTableViewController.swift
Outdated
Show resolved
Hide resolved
|
Thanks very much for the PR @bmihai23 🚀 |
aya-en-amir
pushed a commit
to aya-en-amir/firefox-ios
that referenced
this pull request
Feb 5, 2025
…Controller with ButtonToast (mozilla-mobile#24475) * Replace ActionToast with ButtonToast * Fixed indentation for ButtonToastViewModel declaration * Fix toast appearing unexpectedly after tab deletion * make buttonToast and show method private after feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Before
After
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)