Bugfix FXIOS-11237-11238 Regression on settings change

[lmarceau]

📜 Tickets

Ticket 1
Jira ticket
Github issue

Ticket 2
Jira ticket
Github issue

💡 Description

Changes in #24427 caused some regressions. Apparently reloading in viewWillAppear doesn't work, but viewDidAppear works. One way to easily fix is by using a boolean. I am not a fan of this, but without putting too much time this is what I came up with. Let me know if you think of a better way. Tagging @dicarobinho since I saw you assigned yourselves one of the tickets, so maybe you have some ideas. Thank you!

📝 Checklist

You have to check all boxes before merging

• Filled in the above information (tickets numbers and description of your work)
• Updated the PR name to follow our PR naming guidelines
• Wrote unit tests and/or ensured the tests suite is passing
• When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• If needed, I updated documentation / comments for complex code and public methods
• If needed, added a backport comment (example @Mergifyio backport release/v120)

[dicarobinho]

Hey, @lmarceau. I have tested this and it is working. The approach seems to be fine from my perspective because I have started the investigations on this issue but I have not found a fix, yet.

[PARAIPAN9]

@lmarceau, tested, but the height bug is still there.