Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FXIOS-10711 Log event for tab loss bugs (backport #24328) #24370

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Refactor FXIOS-10711 Log event for tab loss bugs (backport #24328) #24370

merged 1 commit into from
Feb 7, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 27, 2025

📜 Tickets

Jira ticket

💡 Description

Sentry log for tab_loss_detected event.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)
This is an automatic backport of pull request #24328 done by [Mergify](https://mergify.com).

@mattreaganmozilla @mergify
Refactor FXIOS-10711 Log event for tab loss bugs (#24328)
ea654fb 
[FXIOS-10711] Fatal log for tab loss detected

(cherry picked from commit c1a0e89)
@mergify mergify bot requested a review from a team as a code owner January 27, 2025 19:36
@mergify mergify bot requested review from mdotb-moz and removed request for a team January 27, 2025 19:36
@mergify mergify bot mentioned this pull request Jan 27, 2025
Merged
6 tasks
@mattreaganmozilla mattreaganmozilla added the weekly-release Tagging backports for rapid release label Jan 27, 2025
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 34.13%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 32.28

File Coverage
TabErrorTelemetryHelper.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against ea654fb

rvandermeulen
rvandermeulen approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@rvandermeulen rvandermeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for 135.1

@rvandermeulen rvandermeulen merged commit 0924542 into release/v135 Feb 7, 2025
12 checks passed
@rvandermeulen rvandermeulen deleted the mergify/bp/release/v135/pr-24328 branch February 7, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvandermeulen rvandermeulen rvandermeulen approved these changes

@mattreaganmozilla mattreaganmozilla mattreaganmozilla approved these changes

@mdotb-moz mdotb-moz Awaiting requested review from mdotb-moz mdotb-moz is a code owner automatically assigned from mozilla-mobile/fxios-eng

Assignees
No one assigned
Labels
weekly-release Tagging backports for rapid release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mobiletest-ci-bot @rvandermeulen @mattreaganmozilla