Refactor PasswordGeneratorTelemetry to use GleanWrapper
#24332
+22
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raine-Yang-UofT
changed the title
PasswordGeneratorTelemetryPasswordGeneratorTelemetry
Raine-Yang-UofT
changed the title
PasswordGeneratorTelemetryPasswordGeneratorTelemetry to use GleanWrapper
Raine-Yang-UofT
changed the title
PasswordGeneratorTelemetry to use GleanWrapperPasswordGeneratorTelemetry to use GleanWrapper
| super.tearDown() | ||
| } | ||
|
|
||
| func testShowPasswordGeneratorDialog() { | ||
| telemetry.passwordGeneratorDialogShown() | ||
| testCounterMetricRecordingSuccess(metric: GleanMetrics.PasswordGenerator.shown) | ||
| let subject = PasswordGeneratorTelemetry(gleanWrapper: gleanWrapper) |
There was a problem hiding this comment.
nit: generally we prefer to encapsulate the subject into a method like:
private func subject(gleanWrapper: ...) -> PasswordGeneratorTelemetry {
}so we align with other unit tests and if the size of the test increases we have the subject creation in one place.
| XCTAssertEqual(gleanWrapper.incrementCounterCalled, 1) | ||
| } | ||
|
|
||
| private func createSubject() -> PasswordGeneratorTelemetry { |
There was a problem hiding this comment.
Could we inject the Glean wrapper into the createSubject directly, so we don't depend on the class variable ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
This PR refactors the PasswordGeneratorTelemetry to inject a GleanWrapper instead of directly depending on Glean itself.
📜 Changes Made
Replaced direct dependency on Glean in PasswordGeneratorTelemetry with GleanWrapper.
Updated existing unit tests to mock the new GleanWrapper dependency.
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)