Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing: Settlement signing integration #995

Open
wants to merge 9 commits into
base: l-monninger/secure-signing-e2e-integration
Choose a base branch
from

Conversation

musitdev
Copy link
Contributor

@musitdev musitdev commented Jan 10, 2025

Summary

  • RFCs: Link to RFC, Link to RFC, or $\emptyset$.
  • Categories: any of protocol-units, networks, scripts, util, cicd, or misc.

Changelog

  • correct the AWS / Eth integration test.
  • Add local signing test.
  • Update Secp256k1 to normalize sign. Local_signing test was falling.
  • Add signer identifier to the Settlement config.
  • Update Settlement setup to load Signer.
  • Local setup use Anvil default key. Same key for deployment and signing.
  • Update setup for AWS to set AWS account as Attester role for MCR contract. Anvil key is use for deployment and AWS Account for signing.
  • Update MCR Client to use config signer identifier.

Testing

I use this command to start the Movement node:

AWS:
AWS_KMS_KEY_ID=<key_id> AWS_ACCESS_KEY=<aws access> AWS_SECRET_KEY=<aws secret> CELESTIA_LOG_LEVEL=FATAL nix develop --extra-experimental-features nix-command --extra-experimental-features flakes --command bash -c "just movement-full-node native build.setup.eth-local.celestia-local.hsm --keep-project"

Local
CELESTIA_LOG_LEVEL=FATAL nix develop --extra-experimental-features nix-command --extra-experimental-features flakes --command bash -c "just movement-full-node native build.setup.eth-local.celestia-local.hsm --keep-project"

The Setup and MCR client provider definition works. There's an issue with the Tx execution, no block is produced.

Outstanding issues

The node starts, but no block is produced, so no settlement is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants