Alloy signing integration #970
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musitdev
requested review from
l-monninger,
0xmovses and
mzabaluev
as code owners
l-monninger
requested changes
Dec 20, 2024
| } | ||
|
|
||
| #[async_trait::async_trait] | ||
| impl alloy_network::TxSigner<AlloySignature> for HsmSigner { |
There was a problem hiding this comment.
Have you already worked on the code for how this gets integrated? I think it's still probably easier for us to change the usage s.t. we are producing a raw transaction and signing that rather than tightly coupling with a target API.
| /// Instantiate a new signer from an existing `Client` and key ID. | ||
| /// | ||
| /// Retrieves the public key from HMS and calculates the Ethereum address. | ||
| pub async fn new( |
There was a problem hiding this comment.
Because this returns a result, I would call it try_new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
protocol-units,networks,scripts,util,cicd, ormisc.First version of Alloy crate integration for signing with the API. Inspired from the Alloy AWS implementation
alloy_signer_aws::AwsSignerChangelog
Testing
Provide an integration test to test AWS KMS integration. The test can't be used in CI because it needs AWS KMS auth env variable to set to run (
AWS_ACCESS_KEYandAWS_SECRET_KEY).The test start a local Anvil eth node and execute a transfer Tx using an AWS KMS key defined with the
AWS_KEY_IDenv var.AWS_KEY_ID=<>AW key id> AWS_ACCESS_KEY=<access key> AWS_SECRET_KEY=<secret key> cargo test -p movement-signing-alloy test_aws_kms_send_tx -- --nocaptureOutstanding issues