Implement MIP-58 - Trusted Relayer #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create bridge config for DB URL
…ts-missing Exploratory Branch for Addressing Missing Bridge Indexer Events
…ontracts Native Bridge Solidity Contracts
Daily Rate Limiter
Co-authored-by: Andy Golay <[email protected]>
Co-authored-by: Richard Melkonian <[email protected]> Co-authored-by: musitdev <[email protected]>
|
I saw your note @0xmovses, that you're working on CI in a different PR so I'll leave it as is in this branch since you're already on it. |
andygolay
approved these changes
Dec 16, 2024
|
@andygolay we should ignore the |
l-monninger
reviewed
Dec 19, 2024
| vm.warp(1 days - 1); | ||
|
|
||
| uint256 snapshot = vm.snapshot(); | ||
|
|
||
| if (perTransfer >= insuranceBalance / 4) { | ||
| // if the sum of the two transfers is below the rate limit, the second transfer should go through, else it fails |
There was a problem hiding this comment.
I would still do this in a loop.
There was a problem hiding this comment.
@Primata is out sick so I'll add this, thank you.
l-monninger
approved these changes
Dec 19, 2024
| } | ||
| BridgeContractEvent::Completed(_detail) => { | ||
| // Unwrap tested before in validate_state() state can be unwrap | ||
| let state = state_opt.unwrap(); |
|
Let's hold on merge until Liam's recent remarks are addressed. |
|
@l-monninger see the issue with links to your review comments: #971 There are unverified commits in the PR so will need you to do the Squash and merge. |
l-monninger
added
cicd:bridge
cicd:bridge-containers
|
All checks passed. |
l-monninger
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The feature PR contains all the changes in order to implement the Trusted Relayer as specified in MIP-58
Changelog
NativeBridge.sol(this handles both L1 -> L2 and L2 ->L1 directions on ETH in a single contract)Testing
NB. For tests we prefer to run them by file when running the entire test binary in one command, sometimes a client test fails (flaky). A fix for this is simply to force restart the anvil node (tested this fix locally and it works, will arrive shortly in a follow up PR).
rm -rf .data/ && rm -rf .movement/Outstanding issues
See two outstanding cases yet to be fixed in the tracking issue #914. These are ignored currently so as not to block deployment and Front End testing, they can be fixed in paralell with this work.