-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update state logic with the new bridge protocol #886
update state logic with the new bridge protocol #886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one nit and one question.
CC -->CA("Action Remove state") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that it's in the scope of this file to answer, but I'm wondering how the state is removed. Is it assigned a value of "None"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means that we don't manage the state in the relayer anymore. As it's an action, I found that naming it Remove state
is better than done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we stick to done? I think it's better than remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just says that the next action is to remove the state from the internal storage. When a transfer is completed, an action is generated to remove the state from the relayer state storage.
I can name it Done or None, but it's not what it means.
As I say it's not a state of the transfer but an action to be executed when the transfer change it's state to completed.
Co-authored-by: Andy Golay <[email protected]>
A check is failing, I think a rebase is needed. |
CC -->CA("Action Remove state") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we stick to done? I think it's better than remove
Update of the relayer state change adapted to the new bridge protocol.