Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update state logic with the new bridge protocol #886

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

musitdev
Copy link
Contributor

Update of the relayer state change adapted to the new bridge protocol.

Copy link
Contributor

@andygolay andygolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit and one question.

Comment on lines +25 to 26
CC -->CA("Action Remove state")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that it's in the scope of this file to answer, but I'm wondering how the state is removed. Is it assigned a value of "None"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means that we don't manage the state in the relayer anymore. As it's an action, I found that naming it Remove state is better than done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we stick to done? I think it's better than remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just says that the next action is to remove the state from the internal storage. When a transfer is completed, an action is generated to remove the state from the relayer state storage.
I can name it Done or None, but it's not what it means.
As I say it's not a state of the transfer but an action to be executed when the transfer change it's state to completed.

@0xmovses
Copy link
Contributor

A check is failing, I think a rebase is needed.

Comment on lines +25 to 26
CC -->CA("Action Remove state")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we stick to done? I think it's better than remove

@musitdev musitdev added the bridge label Dec 2, 2024
@0xmovses 0xmovses merged commit cbb2c07 into feature/trusted-relayer Dec 2, 2024
76 of 84 checks passed
@musitdev musitdev deleted the musitdev/native_bridge_logic branch December 19, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants