tracking PR, do not merge #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-xyz#2632) - Updated the OP Stack tests for the Mailbox V3 transient storage version - Allowing OPStackHook to send msg.value at the time of message delivery (uses bit masking) - Added LibBit library, will be useful for all the auth hooks which can send `msg.value` - None - Fixes breaking OP Stack tests for hyperlane-xyz/issues#513 - Also fixes hyperlane-xyz#2410 No Unit tests --------- Co-authored-by: Yorke Rhodes <[email protected]> Remove e2e and add yarn build to CI Adding protocol fees (hyperlane-xyz#2640) - Adding protocol fee as a hook - None V3 Yes Fuzz tests --------- Co-authored-by: Yorke Rhodes <[email protected]>
- fixes GasRouter expectRevert message - added TestMerkleRootHook for proof() and fixes MerkleRootMultisig test - fixes ERC5164 tests post v3 changes - added contract name to mailbox and abstractHook error messages - removed unnecessary tests for "message too large" - downgrade slither in actions to 0.3.0 because of their recent "missing inheritance" bug on main - V3 Yes Unit tests
- `quoteDispatch` added to `IPostDispatchHook` interface and the
relevant hooks:
- StaticProtocolFee
- OPStackHook
- InterchainGasPaymaster
- MerkleTreeHook
- PausableHook (no tests)
- DomainRoutingHook (no tests)
- ConfigFallbackDomainRoutingHook
- ConfigurableDomainRoutingHook (no tests)
- `expectEmit` -> `expectCall`
- Quote in V3
Yes
Uint tests
### Description - AggregationHook for v3 ### Drive-by changes None ### Related issues v3 hyperlane-xyz/issues#514 ### Backward compatibility Yes ### Testing Always be fuzzing
- V3 compatible ERC20, ERC721 and all their extensions - Painstakingly migrating hardhat tests to foundry tests for all variants - fixes hyperlane-xyz/issues#577 Yes whole lotta unit tests and poor man's version of integration tests --------- Signed-off-by: -f <[email protected]> Co-authored-by: Yorke Rhodes <[email protected]>
### Description - Removed contracts-bedrock contracts dependency from eth-optimism (which was forcing us to use 0.8.15) - Added local minimal interfaces for the CrossDomainMessenger contract ### Drive-by changes None ### Related issues None ### Backward compatibility Yes ### Testing Unit tests --------- Signed-off-by: -f <[email protected]> Co-authored-by: Yorke Rhodes <[email protected]>
### Description - Adding "InsertedIntoEvent" for standalone indexing of events by the agents ### Drive-by changes None ### Related issues hyperlane-xyz#2313 ### Backward compatibility Yes ### Testing Unit tests
) ### Description - Adds destinationDomain to the `GasPayment` event - recording destination domain as `destination` while reading events for the relayer ### Drive-by changes - none ### Related issues - fixes hyperlane-xyz/issues#475 ### Backward compatibility No, change in event emitted and relayer indexing ### Testing - Unit --------- Signed-off-by: -f <[email protected]> Co-authored-by: Yorke Rhodes <[email protected]>
…erlane-xyz#2681) Co-authored-by: Kunal Arora <[email protected]> Fixes hyperlane-xyz/issues#559
### Description - Consolidating IGPMetadata and OPStackMetadata to versioned GlobalHookMetadata - Add `supportMetadata` to `IPostDispatchHook` - Metadata Schema [0:1] variant [2:33] msg.value [34:65] Gas limit for message (IGP) [66:85] Refund address for message (IGP) [86:] Custom metadata ### Drive-by changes None ### Related issues - fixes hyperlane-xyz/issues#610 ### Backward compatibility No ### Testing Unit tests --------- Co-authored-by: Yorke Rhodes <[email protected]>
### Description - Reorganize solidity directory structure for clarity - Updates router apps (token and helloworld) with changes from hyperlane-xyz#2749 ### Drive-by changes - Merges the hyperlane-token package to solidity and sdk ### Backward compatibility No (removed token package) ### Testing - Unit Tests - Instrumented coverage
### Description - Interceptor is the pair <hook, ism> - `MerkleTreeInterceptorDeployer` for deploying merkle root hook and the `StaticMerkleRootMultisigIsm` on chain ### Drive-by changes - None ### Related issues - addresses hyperlane-xyz/issues#621 ### Backward compatibility Yes ### Testing Manual
### Description - v3 uses the OverheadIgp as the default igp and removing an "inner" igp makes it simpler to deploy and interact with - `InterchainGasPaymaster` has a `setDestinationGasConfigs` which sets it the overhead and the oracle. - the gas overhead gets added it directly to the specified gasAmount. - Downstream changes to the `typescript/*` module in the igpConfig, checke, deployer, etc ### Drive-by changes None ### Related issues - precursor to hyperlane-xyz/issues#623 - related to hyperlane-xyz/issues#637 - missing changes to governor hyperlane-xyz/issues#641 ### Backward compatibility Yes ### Testing Fuzz
### Description It's your favourite PR coming right back... V3 agents! Closes hyperlane-xyz/issues#561 Builds on top of hyperlane-xyz#2742 Depends on hyperlane-xyz#2681 for e2e testing This PR includes: - [x] Merkle tree hook indexer - [x] Merkle tree builder task - [x] Update submitter to trigger retries if no proof is available yet Slightly more detailed overview of the work here: hyperlane-xyz#2720 (comment) <!-- What's included in this PR? --> ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests --> --------- Co-authored-by: -f <[email protected]> Co-authored-by: Trevor Porter <[email protected]> Co-authored-by: Kunal Arora <[email protected]> Co-authored-by: Mattie Conover <[email protected]> Co-authored-by: Guillaume Bouvignies <[email protected]> Co-authored-by: Yorke Rhodes <[email protected]> Co-authored-by: Guillaume Bouvignies <[email protected]>
Co-authored-by: Yorke Rhodes <[email protected]> fixes hyperlane-xyz/issues#624
### Description Part of the remediations from hyperlane-xyz#2746 --------- Co-authored-by: Trevor Porter <[email protected]>
### Description - Deployer changes and artifacts from testnet4 deployment ### Drive-by changes - a single external-secrets instance lives on the cluster, and we are running testnet3 and testnet4 on the same cluster - json parsing errors were silently swallowed, moved to `mustFromJson` to prevent this ### Drive-by changes ### Backward compatibility Yes ### Testing Manual --------- Co-authored-by: Trevor Porter <[email protected]>
### Description - fixes to deploy testnet4 for agents ### Drive-by changes - truncating labels to length 63 - adding `.relayer` to `agentConfig.contextChainNames` ### Related issues - for hyperlane-xyz/issues#574 ### Backward compatibility Yes ### Testing Manual --------- Co-authored-by: Trevor Porter <[email protected]> Co-authored-by: Nam Chu Hoai <[email protected]>
0xmovses/sui updates
add initial unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
Related issues
Backward compatibility
Testing