Merge pull request #8 from movemntdev/0xmovses/unit-tests

add initial unit tests

rust/chains/hyperlane-ethereum/src/mailbox.rs

@@ -440,6 +440,7 @@ mod test {
                 domain: &HyperlaneDomain::Known(KnownHyperlaneDomain::ArbitrumGoerli),
                 // Address doesn't matter because we're using a MockProvider
                 address: H256::default(),
+                modules: None,
             },
         );
 

rust/chains/hyperlane-ethereum/src/provider.rs

@@ -7,7 +7,7 @@ use async_trait::async_trait;
 use derive_new::new;
 use ethers::prelude::Middleware;
 use ethers_core::abi::Address;
-use hyperlane_core::{ethers_core_types, U256};
+use hyperlane_core::{ethers_core_types, LookupKind, U256};
 use tokio::time::sleep;
 use tracing::instrument;
 
@@ -51,7 +51,15 @@ where
     M: Middleware + 'static,
 {
     #[instrument(err, skip(self))]
-    async fn get_block_by_hash(&self, hash: &H256) -> ChainResult<BlockInfo> {
+    async fn get_block_by_hash(&self, hash: LookupKind) -> ChainResult<BlockInfo> {
+        let hash = match hash {
+            LookupKind::Eth(h) => h,
+            _ => {
+                return Err(
+                    ChainCommunicationError::from_contract_error_str("Invalid hash type").into(),
+                )
+            }
+        };
         let block = get_with_retry_on_none(hash, |h| {
             let eth_h256: ethers_core_types::H256 = h.into();
             self.provider.get_block(eth_h256)

rust/chains/hyperlane-fuel/src/provider.rs

@@ -1,7 +1,7 @@
 use async_trait::async_trait;
 
 use hyperlane_core::{
-    BlockInfo, ChainResult, HyperlaneChain, HyperlaneDomain, HyperlaneProvider, TxnInfo, H256, U256,
+    BlockInfo, ChainResult, HyperlaneChain, HyperlaneDomain, HyperlaneProvider, LookupKind, TxnInfo, H256, U256
 };
 
 /// A wrapper around a fuel provider to get generic blockchain information.
@@ -20,7 +20,7 @@ impl HyperlaneChain for FuelProvider {
 
 #[async_trait]
 impl HyperlaneProvider for FuelProvider {
-    async fn get_block_by_hash(&self, hash: &H256) -> ChainResult<BlockInfo> {
+    async fn get_block_by_hash(&self, hash: LookupKind) -> ChainResult<BlockInfo> {
         todo!()
     }
 

rust/chains/hyperlane-sealevel/src/provider.rs

@@ -3,7 +3,7 @@ use std::{str::FromStr, sync::Arc};
 use async_trait::async_trait;
 
 use hyperlane_core::{
-    BlockInfo, ChainResult, HyperlaneChain, HyperlaneDomain, HyperlaneProvider, TxnInfo, H256, U256,
+    BlockInfo, ChainResult, HyperlaneChain, HyperlaneDomain, HyperlaneProvider, LookupKind, TxnInfo, H256, U256
 };
 use solana_sdk::{commitment_config::CommitmentConfig, pubkey::Pubkey};
 
@@ -60,7 +60,7 @@ impl HyperlaneChain for SealevelProvider {
 
 #[async_trait]
 impl HyperlaneProvider for SealevelProvider {
-    async fn get_block_by_hash(&self, _hash: &H256) -> ChainResult<BlockInfo> {
+    async fn get_block_by_hash(&self, _hash: LookupKind) -> ChainResult<BlockInfo> {
         todo!() // FIXME
     }
 

rust/chains/hyperlane-sui/src/client.rs

@@ -1,15 +1,12 @@
 use sui_sdk::{SuiClientBuilder, SuiClient};
-use std::str::FromStr;
-use url::Url;
 
 /// Sui RPC client
 pub struct SuiRpcClient(SuiClient);
 impl SuiRpcClient {
     /// Create a new aptos rpc client from node url
-    pub async fn new(rpc_endpoint: String) -> Result<Self, anyhow::Error> {
-      let client = SuiClientBuilder::default()
-        .build(Url::from_str(&rpc_endpoint).unwrap())
-        .await?;
+    pub async fn new() -> Result<Self, anyhow::Error> {
+      // TODO: feature flag for testnet/mainnet
+      let client = SuiClientBuilder::default().build_testnet().await?;
       Ok(Self(client))
     }
 }
@@ -29,12 +26,11 @@ impl std::fmt::Debug for SuiRpcClient {
 }
 
 mod tests {
-    use super::*;
-    use std::str::FromStr;
-    use url::Url;
+    use crate::SuiRpcClient;
 
     #[tokio::test]
-    async fn test_new() {
-        let rpc_endpoint = "https://fullnode.testnet.sui.io:443";
-
+    async fn test_creates_new_client() {
+        let client = SuiRpcClient::new().await.unwrap();
+    }
+}