Remove rviz2 dependency from rviz_marker_tools
#537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor pipeline planner Make code readable Re-order plan functions Make usable with parallel planning Enable configuring multiple pipelines Add callbacks Cleanup and documentation Add API to set parallel planning callbacks and deprecate functions Pass pipeline map by reference Small clang-tidy fix Update core/src/solvers/pipeline_planner.cpp Co-authored-by: Sebastian Castro <[email protected]> Update core/src/solvers/pipeline_planner.cpp Format Refactor to avoid calling .at(0) twice Use no default stopping criteria Update fallbacks_move demo * Cleanup + address deprecation warnings * Enabling optionally using a property defined pipeline planner map * Address review * Disable humble CI for ros2 branch * Add pipeline planner unittests + some checks * Add short comment
Co-authored-by: Mario Prats <[email protected]>
* Add planner name to trajectory info * Extend unittest
* Reset scene diff in task * Add explanation for scene reset
* Add random pose generator * Fix clang-tidy * Apply suggestions from code review Co-authored-by: Sebastian Castro <[email protected]> * Add warning and format --------- Co-authored-by: Henning Kayser <[email protected]> Co-authored-by: Sebastian Castro <[email protected]>
* Run goalCallback in a seperate asynchronously * Clang-tidy fixes * Replace std::bind with lambdas * Add comment * Format --------- Co-authored-by: JafarAbdi <[email protected]>
… executing the planned trajectory (moveit#355) * Add "controllers" property to Stage and pass them to PlanExecution moveit#123 * Change new property from controller names string to TrajectoryExecutionInfo --------- Co-authored-by: Luca Lach <[email protected]>
…on (moveit#514) * Print warning if no controllers are configured for trajectory execution * Apply suggestions from code review Co-authored-by: Sebastian Castro <[email protected]> * Apply suggestions from code review --------- Co-authored-by: Sebastian Castro <[email protected]>
…lanners Propagate errors from planners.
bmagyar
changed the title
rviz_marker_tools
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ros2 #537 +/- ##
=======================================
Coverage 42.47% 42.47%
=======================================
Files 83 83
Lines 8086 8086
=======================================
Hits 3434 3434
Misses 4652 4652 ☔ View full report in Codecov by Sentry. |
|
Thanks for this patch. I will merge this change into the master branch (ROS1) and then forward-merge into ROS2. |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know it's not intuitive by the name of the package but it actually doesn't depend on Rviz ;)
...and the Humble version is here:
#536