-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documenting instructions for the pick-and-place task #238
Changes from 1 commit
2b18369
162f66c
f1d0f8b
aeb8aa4
2086b04
b093270
c83c99e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -145,12 +145,12 @@ void PickPlaceTask::loadParameters() { | |
} | ||
|
||
// The init function declares all movements for the pick-and-place task. These movements are described below. | ||
void PickPlaceTask::init() { | ||
bool PickPlaceTask::init() { | ||
ROS_INFO_NAMED(LOGNAME, "Initializing task pipeline"); | ||
const std::string object = object_name_; | ||
|
||
// Reset ROS introspection before constructing the new object | ||
// TODO(henningkayser): verify this is a bug, fix if possible | ||
// TODO(v4hn): global storage for Introspection services to enable one-liner | ||
// Movements are collected inside a Task object. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A bit confusing with the previous two lines. Make this a line-end comment (put it at the end of the next line with two separating spaces). |
||
task_.reset(); | ||
task_.reset(new moveit::task_constructor::Task()); | ||
|
@@ -181,8 +181,6 @@ void PickPlaceTask::init() { | |
* Current State * | ||
* * | ||
***************************************************/ | ||
// First, verify that the object is not already attached to the robot. | ||
Stage* current_state_ptr = nullptr; // Forward current_state on to grasp pose generator | ||
{ | ||
auto current_state = std::make_unique<stages::CurrentState>("current state"); | ||
|
||
|
@@ -269,8 +267,8 @@ void PickPlaceTask::init() { | |
stage->properties().set("marker_ns", "grasp_pose"); | ||
stage->setPreGraspPose(hand_open_pose_); | ||
stage->setObject(object); | ||
stage->setAngleDelta(M_PI / 4); | ||
stage->setMonitoredStage(current_state_ptr); // Hook into current state | ||
stage->setAngleDelta(M_PI / 12); | ||
stage->setMonitoredStage(initial_state_ptr); // hook into successful initial-phase solutions | ||
|
||
// Compute joint parameters for a target frame of the end effector. Each target frame equals a grasp pose | ||
// from the previous stage times the inverse of the user-defined grasp_frame_tansform. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.