Made benchmark command arguments passable through ros2 launch args #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjahr
previously approved these changes
Jul 19, 2024
sjahr
reviewed
Jul 19, 2024
…_benchmark.md (See #8 (review))
|
Ready for another cool review 🚀 🌔 ! @sjahr |
sjahr
approved these changes
Jul 22, 2024
CihatAltiparmak
deleted the
fix/pass_benchmark_args_through_commanline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created for users to be able to pass custom benchmark arguments.
In previous versions, it had to be modified launch file itself to set benchmark arguments. Now this arguments can be passed through commanline.
For example:
ros2 launch moveit_middleware_benchmark scenario_perception_pipeline_benchmark.launch.py benchmark_command_args:="--benchmark_out=middleware_benchmark_results.json --benchmark_out_format=json --benchmark_repetitions=1" selected_test_case_index:=0Thanks to https://answers.ros.org/question/396345/ros2-launch-file-how-to-convert-launchargument-to-string/