Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/custom GitHub actions #6

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Feature/custom GitHub actions #6

merged 8 commits into from
Jul 24, 2024

Conversation

CihatAltiparmak
Copy link
Member

No description provided.

@CihatAltiparmak
Copy link
Member Author

CihatAltiparmak commented Jul 16, 2024 •
edited
Loading

Hello @henningkayser , this PR is for Github actions. Could you review it when you are available? Thanks in advance.

Edit: CC @sjahr

@CihatAltiparmak
Copy link
Member Author

CihatAltiparmak commented Jul 16, 2024 •
edited
Loading

Normaly, in this PR, there is a few commits. Don't be frustuated! Seems it's Github relavant problem. It's enough to check out Github action relavant files.

henningkayser
henningkayser previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that GitHub shows the huge list of commits. Are you sure you don't want to rebase your changes onto main? Just reviewing the GHA jobs, I don't see anything wrong with the setup. Do you have any specific questions about it you want to discuss?

@CihatAltiparmak CihatAltiparmak dismissed henningkayser’s stale review July 23, 2024 13:00

The merge-base changed after approval.

@CihatAltiparmak
Copy link
Member Author

CihatAltiparmak commented Jul 24, 2024 •
edited
Loading

As you can see in this link( main...feature/custom_github_actions ) , there are less commits. I don't know why shows a ton of commits. Anyway i have no question at the moment. I think using merging normally instead of rebasing would be more appropriate.

Github has dismissed your approval, not me. @henningkayser Could you give an approval again if it's still okay? I can break the rules, but i don't want.

sjahr
sjahr approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-Approving this for @henningkayser. @CihatAltiparmak you can merge it 👍

@CihatAltiparmak CihatAltiparmak merged commit 563d83b into main Jul 24, 2024
7 of 13 checks passed
@CihatAltiparmak
Copy link
Member Author

Apologies, Seems github relavant bug (https://github.com/orgs/community/discussions/58535) I had to break the rules. @sjahr's approval didn't work

@CihatAltiparmak CihatAltiparmak deleted the feature/custom_github_actions branch October 16, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjahr sjahr sjahr approved these changes

@henningkayser henningkayser henningkayser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CihatAltiparmak @henningkayser @sjahr