Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load robot_description from other namespace (backport #3269) #3325

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 6, 2025

Description

Add namespace to the topic to read robot_description

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • [ / ] Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • [ / ] Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3269 done by [Mergify](https://mergify.com).

* load robot_description from other namespace

* change temp_node's namespace

---------

Co-authored-by: Sebastian Jahr <[email protected]>
(cherry picked from commit af6d762)
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.15%. Comparing base (4a4d1c1) to head (b55d858).
Report is 1 commits behind head on jazzy.

Files with missing lines Patch % Lines
...g/rdf_loader/src/synchronized_string_parameter.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #3325      +/-   ##
==========================================
- Coverage   44.15%   44.15%   -0.00%     
==========================================
  Files         700      700              
  Lines       61683    61682       -1     
  Branches     7477     7477              
==========================================
- Hits        27230    27228       -2     
+ Misses      34286    34285       -1     
- Partials      167      169       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit ddfab7d into jazzy Feb 6, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/jazzy/pr-3269 branch February 6, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants