[Humble] Remove ros2_control 2.13 source build #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Abishalini
approved these changes
Dec 23, 2023
|
I think the source CI is failing because it's pulling from the And ikfast just has been failing due to keys. Can we force merge this? |
sea-bass
changed the title
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## humble #2635 +/- ##
=======================================
Coverage 50.90% 50.90%
=======================================
Files 382 382
Lines 31889 31889
=======================================
Hits 16231 16231
Misses 15658 15658 ☔ View full report in Codecov by Sentry. |
|
@tylerjw @henningkayser Can you force merge this? |
henningkayser
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we were cloning a pretty old version of
ros2_controlhere -- 2.13 when it's now at 2.36.Maybe this will be the thing to fix the
humble_cijob onmainwhich uses the generated Docker image from this branch since #2284?