-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list attribute to @LogRecord annotation #175
base: master
Are you sure you want to change the base?
Conversation
--- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/mouzt/mzt-biz-log?shareId=XXXX-XXXX-XXXX-XXXX).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- bizlog-sdk/src/main/java/com/mzt/logapi/beans/LogRecord.java: Evaluated as low risk
- bizlog-sdk/src/main/java/com/mzt/logapi/starter/support/aop/LogRecordOperationSource.java: Evaluated as low risk
Comments suppressed due to low confidence (2)
bizlog-sdk/src/main/java/com/mzt/logapi/starter/annotation/LogRecord.java:65
- [nitpick] The attribute name 'list' is ambiguous. It should be renamed to something more descriptive, such as 'logRecordList'.
String list() default "";
bizlog-sdk/src/main/java/com/mzt/logapi/starter/support/parse/LogRecordValueParser.java:148
- Ensure that the new behavior introduced by the 'list' attribute is covered by tests.
public List<LogRecord> processLogRecordOps(List<LogRecordOps> logRecordOpsList, MethodExecuteResult methodExecuteResult, Map<String, String> beforeFunctionNameAndReturnMap) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- bizlog-sdk/src/main/java/com/mzt/logapi/service/ILogRecordService.java: Evaluated as low risk
- bizlog-sdk/src/main/java/com/mzt/logapi/starter/support/aop/LogRecordInterceptor.java: Evaluated as low risk
Comments suppressed due to low confidence (2)
bizlog-sdk/src/main/java/com/mzt/logapi/starter/annotation/LogRecord.java:65
- [nitpick] The attribute name 'list' is ambiguous. It should be renamed to 'recordList' for better clarity.
String list() default "";
bizlog-sdk/src/main/java/com/mzt/logapi/beans/LogRecord.java:84
- [nitpick] The attribute name 'list' is too generic and ambiguous. It should be renamed to something more descriptive, such as 'logRecordList'.
private String list;
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
Quality Gate passedIssues Measures |
For more details, open the Copilot Workspace session.