forked from vlm/asn1c
-
Notifications
You must be signed in to change notification settings - Fork 75
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
503c21a
commit c568d29
Showing
10 changed files
with
43 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
@CODE_COVERAGE_RULES@ | ||
|
||
SUBDIRS = . tests | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
@CODE_COVERAGE_RULES@ | ||
|
||
SUBDIRS = check-src | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
@CODE_COVERAGE_RULES@ | ||
|
||
AM_CFLAGS = @ADD_CFLAGS@ | ||
AM_CPPFLAGS = \ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
@CODE_COVERAGE_RULES@ | ||
|
||
check_PROGRAMS = \ | ||
check-ber_tlv_tag \ | ||
check-length \ | ||
|
c568d29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mouse07410 any reason why this merge contain duplicate
in Makefile.am when the original PR does not?
I get a warning when building from your branch:
c568d29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for finding this problem, and my apologies for letting it go unnoticed. Fixed in the master.
c568d29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick response, and many thanks for the work you are doing in helping #99 and #125 mature! APER and Information Object Classes are much needed!
While at your merge of #105, I noted that you choose not to add the file m4/ax_code_coverage.m4. Due to this, I'm not able to build your branch on my old Fedora 20 without modifications (adding the file back to the m4 dir).
The autoconf-archive package on Fedora 20 does not contain ax_code_coverage.m4 (but it does in later releases) so installing autoconf-archive does not get me anywhere.
I guess you removed the file since it is available on your platforms and the bundled one clashes with the system one!? Is there any way to handle both situations? Perhaps some conditional checking if the functions that ax_code_coverage.m4 introduces are present before trying to use them?
c568d29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, please stop commenting here - it's a gross inconvenience for me to track this line. As one possible alternative, feel free to post an issue to my fork. Or to the #105 PR in the original repo. But not at an individual commit.
Second - I see that the original repo has the entire
m4/
directory ignored (i.e., not source-controlled by the Github). The author probably had good reasons to do so. While I can "un-ignore" that directory and its files - I don't have a good feel for the consequences, and therefore am reluctant do to so.The file
ax_code_coverage.m4
is easy to locate, for example, here: https://www.gnu.org/software/autoconf-archive/ax_code_coverage.html