-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Qt.py #403
Merged
Merged
Update Qt.py #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for the PySide6 transition is not working. 😭 Help needed, we need to ensure that code written for PySide6 also runs on PySide2 and vice versa, and these two points are the start of that: |
These tests should work for every binding. def test_midbutton_qt6():
"""QtCore.MidButton was renamed QtCore.MiddleButton in Qt 6"""
from Qt import QtCore, QtCompat
if binding("PySide6"):
assert QtCompat.Qt.MidButton == QtCore.Qt.MiddleButton
else:
assert QtCompat.Qt.MidButton == QtCore.Qt.MidButton
def test_set_font_weight():
"""Qt 6 changed font weights from integers to enums"""
from Qt import QtGui, QtCompat
font = QtGui.QFont()
QtCompat.QFont.setWeight(font, 400) |
This seems solid, but QtCompat for upgrading is still wip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating README, tests and version