Skip to content

Commit

Permalink
msm8937-common: Provide shim for libril-qc-qmi-1.so
Browse files Browse the repository at this point in the history
Change-Id: Ic5d732f3e98ba45c886db9646d6ef30eb0d42bf4
  • Loading branch information
moetayuko authored and JarlPenguin committed Mar 4, 2021
1 parent 1a80ecb commit 1b6b4f5
Show file tree
Hide file tree
Showing 5 changed files with 218 additions and 0 deletions.
4 changes: 4 additions & 0 deletions extract-files.sh
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ function blob_fixup() {
vendor/lib64/libmdmcutback.so)
sed -i "s|libqsap_sdk.so|libqsapshim.so|g" "${2}"
;;

vendor/lib64/libril-qc-qmi-1.so)
patchelf --add-needed "libcutils_shim.so" "${2}"
;;
esac
}

Expand Down
8 changes: 8 additions & 0 deletions libshims/Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,14 @@
LOCAL_PATH := $(call my-dir)

# RIL
include $(CLEAR_VARS)
LOCAL_SRC_FILES := strdup16to8.cpp
LOCAL_SHARED_LIBRARIES := libcutils
LOCAL_MODULE := libcutils_shim
LOCAL_MODULE_TAGS := optional
LOCAL_VENDOR_MODULE := true
include $(BUILD_SHARED_LIBRARY)

include $(CLEAR_VARS)
LOCAL_SRC_FILES := libqsap_shim.c
LOCAL_SHARED_LIBRARIES := libqsap_sdk liblog libcutils libutils
Expand Down
37 changes: 37 additions & 0 deletions libshims/jstring.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/*
* Copyright (C) 2006 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#pragma once

#include <stdint.h>
#include <stddef.h>

#ifdef __cplusplus
extern "C" {
#endif

#if __STDC_VERSION__ < 201112L && __cplusplus < 201103L
typedef uint16_t char16_t;
#endif
// otherwise char16_t is a keyword with the right semantics

extern char * strndup16to8 (const char16_t* s, size_t n);
extern size_t strnlen16to8 (const char16_t* s, size_t n);
extern char * strncpy16to8 (char *dest, const char16_t*s, size_t n);

#ifdef __cplusplus
}
#endif
168 changes: 168 additions & 0 deletions libshims/strdup16to8.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,168 @@
/* libs/cutils/strdup16to8.c
**
** Copyright 2006, The Android Open Source Project
**
** Licensed under the Apache License, Version 2.0 (the "License");
** you may not use this file except in compliance with the License.
** You may obtain a copy of the License at
**
** http://www.apache.org/licenses/LICENSE-2.0
**
** Unless required by applicable law or agreed to in writing, software
** distributed under the License is distributed on an "AS IS" BASIS,
** WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
** See the License for the specific language governing permissions and
** limitations under the License.
*/

#include "jstring.h"

#include <assert.h>
#include <limits.h> /* for SIZE_MAX */
#include <stdlib.h>


/**
* Given a UTF-16 string, compute the length of the corresponding UTF-8
* string in bytes.
*/
extern size_t strnlen16to8(const char16_t* utf16Str, size_t len)
{
size_t utf8Len = 0;

/* A small note on integer overflow. The result can
* potentially be as big as 3*len, which will overflow
* for len > SIZE_MAX/3.
*
* Moreover, the result of a strnlen16to8 is typically used
* to allocate a destination buffer to strncpy16to8 which
* requires one more byte to terminate the UTF-8 copy, and
* this is generally done by careless users by incrementing
* the result without checking for integer overflows, e.g.:
*
* dst = malloc(strnlen16to8(utf16,len)+1)
*
* Due to this, the following code will try to detect
* overflows, and never return more than (SIZE_MAX-1)
* when it detects one. A careless user will try to malloc
* SIZE_MAX bytes, which will return NULL which can at least
* be detected appropriately.
*
* As far as I know, this function is only used by strndup16(),
* but better be safe than sorry.
*/

/* Fast path for the usual case where 3*len is < SIZE_MAX-1.
*/
if (len < (SIZE_MAX-1)/3) {
while (len != 0) {
len--;
unsigned int uic = *utf16Str++;

if (uic > 0x07ff)
utf8Len += 3;
else if (uic > 0x7f || uic == 0)
utf8Len += 2;
else
utf8Len++;
}
return utf8Len;
}

/* The slower but paranoid version */
while (len != 0) {
len--;
unsigned int uic = *utf16Str++;
size_t utf8Cur = utf8Len;

if (uic > 0x07ff)
utf8Len += 3;
else if (uic > 0x7f || uic == 0)
utf8Len += 2;
else
utf8Len++;

if (utf8Len < utf8Cur) /* overflow detected */
return SIZE_MAX-1;
}

/* don't return SIZE_MAX to avoid common user bug */
if (utf8Len == SIZE_MAX)
utf8Len = SIZE_MAX-1;

return utf8Len;
}


/**
* Convert a Java-Style UTF-16 string + length to a JNI-Style UTF-8 string.
*
* This basically means: embedded \0's in the UTF-16 string are encoded
* as "0xc0 0x80"
*
* Make sure you allocate "utf8Str" with the result of strlen16to8() + 1,
* not just "len".
*
* Please note, a terminated \0 is always added, so your result will always
* be "strlen16to8() + 1" bytes long.
*/
extern char* strncpy16to8(char* utf8Str, const char16_t* utf16Str, size_t len)
{
char* utf8cur = utf8Str;

/* Note on overflows: We assume the user did check the result of
* strnlen16to8() properly or at a minimum checked the result of
* its malloc(SIZE_MAX) in case of overflow.
*/
while (len != 0) {
len--;
unsigned int uic = *utf16Str++;

if (uic > 0x07ff) {
*utf8cur++ = (uic >> 12) | 0xe0;
*utf8cur++ = ((uic >> 6) & 0x3f) | 0x80;
*utf8cur++ = (uic & 0x3f) | 0x80;
} else if (uic > 0x7f || uic == 0) {
*utf8cur++ = (uic >> 6) | 0xc0;
*utf8cur++ = (uic & 0x3f) | 0x80;
} else {
*utf8cur++ = uic;

if (uic == 0) {
break;
}
}
}

*utf8cur = '\0';

return utf8Str;
}

/**
* Convert a UTF-16 string to UTF-8.
*
*/
char * strndup16to8 (const char16_t* s, size_t n)
{
if (s == NULL) {
return NULL;
}

size_t len = strnlen16to8(s, n);

/* We are paranoid, and we check for SIZE_MAX-1
* too since it is an overflow value for our
* strnlen16to8 implementation.
*/
if (len >= SIZE_MAX-1)
return NULL;

char* ret = static_cast<char*>(malloc(len + 1));
if (ret == NULL)
return NULL;

strncpy16to8 (ret, s, n);

return ret;
}
1 change: 1 addition & 0 deletions msm8937.mk
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,7 @@ PRODUCT_PACKAGES += \

# Shims
PRODUCT_PACKAGES += \
libcutils_shim \
libqsapshim

# Soong namespaces
Expand Down

0 comments on commit 1b6b4f5

Please sign in to comment.