Feat/writer registries #578
Conversation
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
==========================================
+ Coverage 90.70% 90.76% +0.05%
==========================================
Files 56 56
Lines 4572 4623 +51
==========================================
+ Hits 4147 4196 +49
- Misses 425 427 +2
Continue to review full report at Codecov.
|
After PR mosdef-hub#567, which brought in the addition of concept of Registries to save/load files; Only the json methods are currently using the registries but can be extended to other formats as well. This PR introduces the overhaul to the `xyz` file format, one of the simpler cases. So far, this seems to have worked quite well.
justinGilmer
force-pushed
the
feat/writer_registries
branch
from
f88db12 to
4803276
Compare
|
This pull request introduces 6 alerts when merging 2c5585b into 8f58b22 - view on LGTM.com new alerts:
|
|
This pull request introduces 6 alerts when merging 2b79b94 into 8f58b22 - view on LGTM.com new alerts:
|
|
This pull request introduces 6 alerts when merging 231103d into 8f58b22 - view on LGTM.com new alerts:
|
|
This pull request introduces 6 alerts when merging aaf0d68 into 7acc05e - view on LGTM.com new alerts:
|
|
Note @umesh-timalsina @daico007 I just updated this with the ability to stack multiple @saves_as(".lammps")
@saves_as(".lammpsdata")
@saves_as(".data")
def write_lammpsdata(topology, filename, atom_style="full"): |
|
This pull request introduces 6 alerts when merging 510d0cc into 45036e9 - view on LGTM.com new alerts:
|
|
This pull request introduces 6 alerts when merging f699d11 into 45036e9 - view on LGTM.com new alerts:
|
|
This pull request introduces 6 alerts when merging 59c6cc6 into 4564af6 - view on LGTM.com new alerts:
|
|
This pull request introduces 6 alerts when merging e5d5762 into 0ffa346 - view on LGTM.com new alerts:
|
After PR #567, which brought in the addition of concept of Registries to
save/load files; Only the json methods are currently using the registries but can be extended to other formats as well.
This PR introduces the overhaul to the
xyzfile format, one of thesimpler cases. So far, this seems to have worked quite well.
This currently depends on PR #567, so this should not be merged until 567 is merged.